Update matrix of options to support macos again. #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new versions of MacOS Runners are ARM based and the setup-python action doesn't support older python versions (before 3.11) on ARM. This PR updates the matrix to include both macos-latest (arm) and macos-13 (the last x86_64 version). It then use excludes to only run new python versions on ARM and older versions of x86. We miss out on coverage of someone compiling their own version of < 3.11 python on apple silicon, but I don't think that's too much of an issue. If we ever need to bump the minimum python version beyond 3.11 we can remove this. It also removes the parallelism limiters on the matrix computation (not sure why I added that, GitHub lets you have infinite parallel runners for now lol).
craffel
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new versions of MacOS Runners are ARM based and the setup-python action doesn't support older python versions (before 3.11) on ARM.
This PR updates the matrix to include both macos-latest (arm) and macos-13 (the last x86_64 version). It then use excludes to only run new python versions on ARM and older versions of x86.
We miss out on coverage of someone compiling their own version of < 3.11 python on apple silicon, but I don't think that's too much of an issue.
If we ever need to bump the minimum python version beyond 3.11 we can remove this.
It also removes the parallelism limiters on the matrix computation (not sure why I added that, GitHub lets you have infinite parallel runners for now lol).
closes #245